Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a fix for never-union #9218

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Add a fix for never-union #9218

merged 1 commit into from
Dec 21, 2023

Conversation

charliermarsh
Copy link
Member

Summary

Enables us to rewrite Never | int as int.

@charliermarsh charliermarsh changed the title Add a fix for never-union Add a fix for never-union Dec 20, 2023
@charliermarsh charliermarsh added fixes Related to suggested fixes for violations preview Related to preview mode features labels Dec 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 20, 2023 •
edited
Loading

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

ℹ️ ecosystem check detected linter changes. (+3 -0 violations, +0 -0 fixes in 1 projects; 40 projects unchanged)

bokeh/bokeh (+3 -0 violations, +0 -0 fixes) 

ruff check --no-cache --exit-zero --preview --select ALL

+ tests/support/plugins/selenium.py:118:88: RUF020 [*] `NoReturn | T` is equivalent to `T`
+ tests/support/plugins/selenium.py:132:47: RUF020 [*] `NoReturn | T` is equivalent to `T`
+ tests/support/plugins/selenium.py:146:47: RUF020 [*] `NoReturn | T` is equivalent to `T`

Changes by rule (1 rules affected)

code total + violation - violation + fix - fix
RUF020 3 3 0 0 0

Base automatically changed from charlie/union to main December 21, 2023 20:53
@charliermarsh charliermarsh force-pushed the charlie/union-fix branch 2 times, most recently from bc76943 to 25c7938 Compare December 21, 2023 20:55
@charliermarsh charliermarsh enabled auto-merge (squash) December 21, 2023 20:57
@charliermarsh charliermarsh merged commit b0ae119 into main Dec 21, 2023
16 checks passed
@charliermarsh charliermarsh deleted the charlie/union-fix branch December 21, 2023 21:01
@tusharsadhwani tusharsadhwani mentioned this pull request May 3, 2024
Merged
zanieb pushed a commit that referenced this pull request May 3, 2024
@tusharsadhwani
Remove unnecessary check for RUF020 enabled (#11268)
f3284fd 
## Summary

In #9218 `Rule::NeverUnion` was partially removed from a
`checker.any_enabled` call. This makes the change consistent.

## Test Plan

`cargo test`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
fixes Related to suggested fixes for violations preview Related to preview mode features
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@charliermarsh